vppinfra: fix clib_bitmap_will_expand() result inversion 50/38250/2
authorVladislav Grishenko <[email protected]>
Tue, 14 Feb 2023 07:34:29 +0000 (12:34 +0500)
committerDamjan Marion <[email protected]>
Mon, 6 Mar 2023 14:31:47 +0000 (14:31 +0000)
commita20afdc845f4e901f7d3e6974e59a0dc2e8bf427
treedd2360ee691903cd058af8fda23008be46e3ea73
parent1ee334c6f86b3e814aca1443ec7dfccdfc34ab26
vppinfra: fix clib_bitmap_will_expand() result inversion

Pool's pool_put_will_expand() calls clib_bitmap_will_expand(),
so every put except ones that leads to free_bitmap reallocation
will get false positive results and vice versa.

Unfortunatelly there's no related test and existing bitmap
tests are failing silently with false positive result as well.

Fortunatelly neither clib_bitmap_will_expand() nor
pool_put_will_expand() are being used by current vpp codebase.

Type: fix
Signed-off-by: Vladislav Grishenko <[email protected]>
Change-Id: Id5bb900cf6a1b1002d37670f5c415c74165b5421
src/plugins/unittest/bitmap_test.c
src/vppinfra/bitmap.h
test/asf/test_vppinfra.py