Code Review / honeycomb.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 9b39d67) | patch
WriteTransaction: make sure TransactionCommitFailedException is thrown 89/12989/2
authorMarek Gradzki <mgradzki@cisco.com>
Fri, 13 Apr 2018 11:38:16 +0000 (13:38 +0200)
committerMarek Gradzki <mgradzki@cisco.com>
Mon, 11 Jun 2018 14:21:21 +0000 (16:21 +0200)
commitaedef4e46dac4b991072034ee07e3f35b6e5a700
treed2670e825e34d1001b8bd3f1ad0a33804067c69ftree | snapshot
parent9b39d6767724d824f7ed8070138319ff0411dabbcommit | diff
WriteTransaction: make sure TransactionCommitFailedException is thrown

DataTreeModification.ready() used by DataModification.validate()
might throw IllegalArgumentException in case of missing mandatory nodes.

Use broader Exception type in WriteTransaction.submit()
to make sure contract defined by AsyncWriteTransaction is preserved.

Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/WriteTransaction.java diff | blob | history
infra/it/it-test/pom.xml diff | blob | history
infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/TestValidate.java [new file with mode: 0644] blob
infra/it/it-test/src/test/resources/messages/commit.xml [new file with mode: 0644] blob
infra/it/it-test/src/test/resources/messages/edit-config/edit-config-missing-mandatory-node.xml [new file with mode: 0644] blob
infra/it/it-test/src/test/resources/messages/rpc-reply_ok.xml [new file with mode: 0644] blob
infra/it/it-test/src/test/resources/models/test-validate.yang [new file with mode: 0644] blob
ARCHIVED- 2020-12-03 at the request of the project