Fix double free in af_packet api/cli 23/3323/3
authorIvan Kelly <ivan@midokura.com>
Fri, 7 Oct 2016 16:02:43 +0000 (18:02 +0200)
committerChris Luke <chris_luke@comcast.com>
Mon, 10 Oct 2016 16:23:31 +0000 (16:23 +0000)
commitbfe737a1b29afea2e10248b8c9fa800148fbd573
tree2bb706ed1d297cc36c1b00a14b4087b0c0fcf7be
parent4c42e913c4f9723d27f6501f6e1b6a13b9c2f9f8
Fix double free in af_packet api/cli

The api was allocating a vector for the name, passing it, then freeing
it, on create. The cli allocated, passed then forgot about it.

af_packet_create_if was storing a reference to the name, which in the
case of the api, meant it was referencing dead memory. On
af_packet_delete_if this reference was freed, so in the api case, there
was a double free.

Also, the cli for delete leaked the name.

Change-Id: I4d572bd2936eaf8ea7a0a8ff282e83ac2bf1b062
Signed-off-by: Ivan Kelly <ivan@midokura.com>
vnet/vnet/devices/af_packet/af_packet.c
vnet/vnet/devices/af_packet/cli.c