Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 418b225) | patch
api: mark api_trace_command_fn thread-safe 98/24498/1
authorDave Barach <dave@barachs.net>
Thu, 23 Jan 2020 13:44:40 +0000 (08:44 -0500)
committerDave Barach <openvpp@barachs.net>
Thu, 23 Jan 2020 15:35:51 +0000 (15:35 +0000)
commitc385a95e8ed81c39d02114f975850ea52ae7dc17
tree99b9a247805398dde18dbe8aa4ec498acd575155tree | snapshot
parent418b225931634f6d113d2971cb9550837d69929dcommit | diff
api: mark api_trace_command_fn thread-safe

Binary API trace replay with multiple worker threads depends in many
cases on worker thread graph replica maintenance. If we (implicitly)
assert a worker thread barrier at the debug CLI level, all graph
replica changes are deferred until the replay operation completes. If
an interface is deleted, the wheels may fall off.

Type: fix
Ticket: VPP-1824

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b07d43f8501caa5519e5ff9ae4c19dc2661cc84
src/vlibmemory/vlib_api_cli.c diff | blob | history
Vector Packet Processing