ipsec: fix AES CBC IV generation (CVE-2022-46397) 50/38150/2
authorBenoît Ganne <bganne@cisco.com>
Tue, 18 Jan 2022 14:56:41 +0000 (15:56 +0100)
committerDave Wallace <dwallacelf@gmail.com>
Wed, 8 Feb 2023 01:06:52 +0000 (01:06 +0000)
commitc6fe2c3053b7534e38fbf04d4442fc3f166a55c0
tree6fecebc05f0955d9b6fc244e6c4624060fad8983
parent2a3d41cea2b854aec11871719eb6bb967089ad33
ipsec: fix AES CBC IV generation (CVE-2022-46397)

For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/crypto/crypto.h
src/vnet/ipsec/esp_encrypt.c
src/vnet/ipsec/ipsec_sa.h