unittest: Skip string test case for sizeof (src) > sizeof (dst) 43/28343/1
authorSteven Luong <sluong@cisco.com>
Tue, 25 Feb 2020 19:06:17 +0000 (11:06 -0800)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Thu, 13 Aug 2020 08:12:25 +0000 (08:12 +0000)
commitdf76172d8add7ada1d804041f972d1218e6cd009
tree9dcc37adebc7051b4f0d75a3d4160dcc2100ac32
parentf17be8ae96fdb09693bdfa07eabb56392aff3ba1
unittest: Skip string test case for sizeof (src) > sizeof (dst)

coverity complains that the subject test may cause dst buffer overrun
problem and it is right. The problem is when __builtin_constant_p (n)
returns true, memcpy_s_inline skips all the errors checking and does the
copy blindly. Please see the code in memcpy_s_inline.

The fix is to skip the subject test when the aformentioned builtin function
returns true.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I50de91cc0c853a134b3bcf3b0cd8d45d7668b092
(cherry picked from commit 2da39718f560478678caacccd198ee4c0c9673c3)
MAINTAINERS
src/plugins/unittest/string_test.c