bfd: fix buffer leak when cannot send periodic packets 42/40042/2
authorAlexander Chernavin <achernavin@netgate.com>
Thu, 23 Nov 2023 11:36:09 +0000 (11:36 +0000)
committerDave Wallace <dwallacelf@gmail.com>
Fri, 1 Dec 2023 19:29:55 +0000 (19:29 +0000)
commitf9c322be7da6a23c467526f5323a3fcdcc9aad86
tree963a73bdecd6ae3544c6274db89ac426b7400ec6
parentb75bde18c44420021ae9800b584b1c644fed2a87
bfd: fix buffer leak when cannot send periodic packets

When a periodic BFD packet cannot be sent because the interface is
disabled, the allocated buffer needs to be freed. This currently will
occur for IPv4 sessions. However, buffers will leak for IPv6 sessions as
in this case, bfd_transport_control_frame() and bfd_transport_udp6()
will not indicate failure.

With this fix, stop always returning success in bfd_transport_udp6() and
start returning the actual return value.

Type: fix
Change-Id: I5fa4d9206e32cccae3053ef24966d80e2022fc81
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
(cherry picked from commit 1f4023d55d7a9c777465d24065e91fc076602fb0)
src/vnet/bfd/bfd_udp.c