misc: fix ip6_neighbor_cmd 48/26248/3
authorDave Barach <[email protected]>
Mon, 30 Mar 2020 15:06:46 +0000 (11:06 -0400)
committerAndrew Yourtchenko <[email protected]>
Wed, 1 Apr 2020 11:41:56 +0000 (11:41 +0000)
commitd643e5f30155e46aa6f345aa52d8ef5026d879a6
treec44177c1696b80a5a7c7cd643d212787237d98db
parent88e47b0e476d40636f165dd55fc0c5f0542f81b9
misc: fix ip6_neighbor_cmd

The option parsing loop had "break" statements included in each
'if (unformat (line_input, "this-option ...") option_values=xxx;'
statement.

Result: the code would silently ignore all but the first
option. Probably broken forever, not easy to spot because the code
looks OK even though it's badly broken.

Manual cherrypick: the function name has changed, the code has
moved to a different file, and the MAINTAINERS file entry doesn't
exist in 19.08.

Type: fix

Signed-off-by: Dave Barach <[email protected]>
(cherry picked from commit 7249b90ab21c20138907e692dcb6032aea9e2f0f)
Change-Id: Ie06bb083645302848a19ecc9ad2934927de01f62
src/vnet/ip/ip6_neighbor.c