Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b89dcf8) | patch
ipsec: fix AES CBC IV generation (CVE-2022-46397) 51/38151/1
authorBenoît Ganne <bganne@cisco.com>
Tue, 18 Jan 2022 14:56:41 +0000 (15:56 +0100)
committerDave Wallace <dwallacelf@gmail.com>
Sat, 4 Feb 2023 02:04:11 +0000 (21:04 -0500)
commit474f0ba2ab7a79691b60a2a973ca37f65501934e
treea37fa3d80de641cfcc163d060451a38bc668146ctree | snapshot
parentb89dcf8241a729b8a86dc1358f61fa2af8ab0c2ccommit | diff
ipsec: fix AES CBC IV generation (CVE-2022-46397)

For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/crypto/crypto.h diff | blob | history
src/vnet/ipsec/esp_encrypt.c diff | blob | history
src/vnet/ipsec/ipsec_sa.h diff | blob | history
Vector Packet Processing