ping: fix buffer allocator error handling 70/26470/2
authorDave Barach <[email protected]>
Wed, 8 Apr 2020 16:03:32 +0000 (12:03 -0400)
committerDave Wallace <[email protected]>
Mon, 13 Apr 2020 15:05:12 +0000 (15:05 +0000)
commit5e62c84bb7058b58d9f0fa3b5eff9af93c073274
treeb3cbd3e3d4955a1f35948e6ddf86870de876b61a
parent7f094c2212cf906227ecb06e00f3082d886b32a0
ping: fix buffer allocator error handling

The code sets f->n_vectors = n_to_send, but it can bail out of the
loop if vlib_buffer_copy(...) returns 0.

Need to fix f->n_vectors in the error return path, or we enqueue some
number of 0xfefefefe buffer indices in a debug image or worse in a
production image.

Type: fix

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I2d886266006c6c1c2f9ef8e3b95eb46ac6c0b3df
(cherry picked from commit 8324c55f95dd5ddbf1f5f9c47907204a12e152ef)
src/plugins/ping/ping.c