Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 864af09) | patch
api: mark api_trace_command_fn thread-safe 97/24497/2
authorDave Barach <dave@barachs.net>
Thu, 23 Jan 2020 13:44:40 +0000 (08:44 -0500)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Fri, 24 Jan 2020 00:21:06 +0000 (00:21 +0000)
commit9af7a98cf854a6b43fc681235d092c445a505589
treeee0778316e08df1b2fe8cda357cc0fa7a8cc8c22tree | snapshot
parent864af095087184e133e3e3b0c546c7d65866f63dcommit | diff
api: mark api_trace_command_fn thread-safe

Binary API trace replay with multiple worker threads depends in many
cases on worker thread graph replica maintenance. If we (implicitly)
assert a worker thread barrier at the debug CLI level, all graph
replica changes are deferred until the replay operation completes. If
an interface is deleted, the wheels may fall off.

Type: fix
Ticket: VPP-1824

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b07d43f8501caa5519e5ff9ae4c19dc2661cc84
src/vlibmemory/vlib_api_cli.c diff | blob | history
Vector Packet Processing