Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: f53edbc) | patch
ipsec: fix AES CBC IV generation (CVE-2022-46397) 59/38159/1 stable/2005
authorBenoît Ganne <bganne@cisco.com>
Tue, 18 Jan 2022 14:56:41 +0000 (15:56 +0100)
committerBenoît Ganne <bganne@cisco.com>
Tue, 7 Feb 2023 13:34:27 +0000 (14:34 +0100)
commit3c1021a679193475cbee59a717a53ece009e273f
tree880c7ea4d46f3237998f62730d4814981c74754ftree | snapshot
parentf53edbc3b4e35b368361e0c61b1adf0d5ab70bf7commit | diff
ipsec: fix AES CBC IV generation (CVE-2022-46397)

For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/crypto/crypto.h diff | blob | history
src/vnet/ipsec/esp_encrypt.c diff | blob | history
src/vnet/ipsec/ipsec_sa.h diff | blob | history
Vector Packet Processing