Code Review / vpp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 73fdb09) | patch
ipsec: fix AES CBC IV generation (CVE-2022-46397) 52/38152/1 stable/2202
authorBenoît Ganne <bganne@cisco.com>
Tue, 18 Jan 2022 14:56:41 +0000 (15:56 +0100)
committerDave Wallace <dwallacelf@gmail.com>
Sat, 4 Feb 2023 02:04:39 +0000 (21:04 -0500)
commitbf73623ecc24af3dd0637c8cb5e204b1edebed22
tree16f9947ace817a501c67f96c6ca02598681fc75dtree | snapshot
parent73fdb095b36ce6b780cf6d1a6c20effe2e9a684acommit | diff
ipsec: fix AES CBC IV generation (CVE-2022-46397)

For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
src/vnet/crypto/crypto.h diff | blob | history
src/vnet/ipsec/esp_encrypt.c diff | blob | history
src/vnet/ipsec/ipsec_sa.h diff | blob | history
Vector Packet Processing