- check input sw_if_index to make sure it is sane. Coverity actually
complains about it.
- return rv. Some of the APIs handlers were not passing back the rv.
Type: improvement
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8378ea948af561ba2bd9b02fb10bf4f9df2a2cd2
clib_memset (ap, 0, sizeof (*ap));
ap->group = ntohl (mp->bond_sw_if_index);
clib_memset (ap, 0, sizeof (*ap));
ap->group = ntohl (mp->bond_sw_if_index);
+ VALIDATE_SW_IF_INDEX (mp);
ap->member = ntohl (mp->sw_if_index);
ap->is_passive = mp->is_passive;
ap->is_long_timeout = mp->is_long_timeout;
bond_add_member (vm, ap);
ap->member = ntohl (mp->sw_if_index);
ap->is_passive = mp->is_passive;
ap->is_long_timeout = mp->is_long_timeout;
bond_add_member (vm, ap);
REPLY_MACRO (VL_API_BOND_ADD_MEMBER_REPLY);
}
REPLY_MACRO (VL_API_BOND_ADD_MEMBER_REPLY);
}
clib_memset (ap, 0, sizeof (*ap));
ap->group = ntohl (mp->bond_sw_if_index);
clib_memset (ap, 0, sizeof (*ap));
ap->group = ntohl (mp->bond_sw_if_index);
+ VALIDATE_SW_IF_INDEX (mp);
ap->member = ntohl (mp->sw_if_index);
ap->is_passive = mp->is_passive;
ap->is_long_timeout = mp->is_long_timeout;
bond_add_member (vm, ap);
ap->member = ntohl (mp->sw_if_index);
ap->is_passive = mp->is_passive;
ap->is_long_timeout = mp->is_long_timeout;
bond_add_member (vm, ap);
REPLY_MACRO (VL_API_BOND_ENSLAVE_REPLY);
}
REPLY_MACRO (VL_API_BOND_ENSLAVE_REPLY);
}
ap->weight = ntohl (mp->weight);
bond_set_intf_weight (vm, ap);
ap->weight = ntohl (mp->weight);
bond_set_intf_weight (vm, ap);
REPLY_MACRO (VL_API_SW_INTERFACE_SET_BOND_WEIGHT_REPLY);
}
REPLY_MACRO (VL_API_SW_INTERFACE_SET_BOND_WEIGHT_REPLY);
}
ap->member = ntohl (mp->sw_if_index);
bond_detach_member (vm, ap);
ap->member = ntohl (mp->sw_if_index);
bond_detach_member (vm, ap);
REPLY_MACRO (VL_API_BOND_DETACH_SLAVE_REPLY);
}
REPLY_MACRO (VL_API_BOND_DETACH_SLAVE_REPLY);
}
ap->member = ntohl (mp->sw_if_index);
bond_detach_member (vm, ap);
ap->member = ntohl (mp->sw_if_index);
bond_detach_member (vm, ap);
REPLY_MACRO (VL_API_BOND_DETACH_MEMBER_REPLY);
}
REPLY_MACRO (VL_API_BOND_DETACH_MEMBER_REPLY);
}