- CID 178225: Constant expression result
- CID 178220: Logically dead code
- CID 178222: Logically dead code
- CID 178227: Logically dead code
- CID 178223: Same on both sides
- CID 178226: Same on both sides
Change-Id: Ie0c80edb41390cf2308e54938be85d865e292138
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
* */
vcom_fd_set_merge (
/* dest, select sets */
* */
vcom_fd_set_merge (
/* dest, select sets */
- __readfds || __writefds || __exceptfds ?
- &new_nfds : NULL,
__readfds,
__writefds,
__exceptfds,
__readfds,
__writefds,
__exceptfds,
{
rv = vppcom_session_read (vsock->sid, __buf, __nbytes);
}
{
rv = vppcom_session_read (vsock->sid, __buf, __nbytes);
}
+ /* coverity[CONSTANT_EXPRESSION_RESULT] */
while (rv == -EAGAIN || rv == -EWOULDBLOCK);
return rv;
}
while (rv == -EAGAIN || rv == -EWOULDBLOCK);
return rv;
}
+ /* coverity[CONSTANT_EXPRESSION_RESULT] */
while ((rv == -EAGAIN || rv == -EWOULDBLOCK) && total == 0);
return total;
}
while ((rv == -EAGAIN || rv == -EWOULDBLOCK) && total == 0);
return total;
}
return -EDESTADDRREQ;
}
/* not a vppcom supported address family */
return -EDESTADDRREQ;
}
/* not a vppcom supported address family */
- if ((__addr->sa_family != AF_INET) || (__addr->sa_family != AF_INET6))
+ if (!((__addr->sa_family == AF_INET) ||
+ (__addr->sa_family == AF_INET6)))
{
time_to_wait = (double) 0;
}
{
time_to_wait = (double) 0;
}
- else if (__timeout < 0)
- {
- time_to_wait = ~0;
- }
}
return vppcom_poll (__fds, __nfds, time_to_wait);
}
return vppcom_poll (__fds, __nfds, time_to_wait);
/* *INDENT-OFF* */
pool_flush (vepitem, vsm->vepitems,
({
/* *INDENT-OFF* */
pool_flush (vepitem, vsm->vepitems,
({
- if (vepitem->type == FD_TYPE_EPOLL || FD_TYPE_VCOM_SOCKET)
+ if ((vepitem->type == FD_TYPE_EPOLL) ||
+ (vepitem->type == FD_TYPE_VCOM_SOCKET))
- vcom_socket_epoll_ctl1 (vepitem->epfd, EPOLL_CTL_DEL,
+ vcom_socket_epoll_ctl1 (vepitem->epfd, EPOLL_CTL_DEL,
vepitem->fd, NULL);
vepitem_init (vepitem);
}
vepitem->fd, NULL);
vepitem_init (vepitem);
}
#ifdef NDEBUG
#define SWRAP_LOG(...)
#else
#ifdef NDEBUG
#define SWRAP_LOG(...)
#else
+static unsigned int swrap_log_lvl = SWRAP_LOG_WARN;
+
static void
swrap_log (enum swrap_dbglvl_e dbglvl, const char *func,
const char *format, ...)
static void
swrap_log (enum swrap_dbglvl_e dbglvl, const char *func,
const char *format, ...)
{
char buffer[1024];
va_list va;
{
char buffer[1024];
va_list va;
- unsigned int lvl = SWRAP_LOG_WARN;
va_start (va, format);
vsnprintf (buffer, sizeof (buffer), format, va);
va_end (va);
va_start (va, format);
vsnprintf (buffer, sizeof (buffer), format, va);
va_end (va);
+ if (dbglvl <= swrap_log_lvl)