devices: allow link state down with netlink 11/28411/1
authorMatthew Smith <mgsmith@netgate.com>
Fri, 24 Apr 2020 18:43:12 +0000 (13:43 -0500)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Thu, 13 Aug 2020 17:20:47 +0000 (17:20 +0000)
Type: fix

Use the up parameter in vnet_netlink_set_link_state(). It was
ignoring the parameter and always setting IFF_UP on an interface.

Change-Id: I0d44406d982afbdc43bc6b26d0f22c0bdd47abdc
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
(cherry picked from commit 81284163a293759bc5c2d6a124639c6796589d15)

src/vnet/devices/netlink.c

index a954fef..298a3e4 100644 (file)
@@ -184,7 +184,7 @@ vnet_netlink_set_link_state (int ifindex, int up)
   vnet_netlink_msg_t m;
   struct ifinfomsg ifmsg = { 0 };
 
-  ifmsg.ifi_flags = IFF_UP;
+  ifmsg.ifi_flags = ((up) ? IFF_UP : 0);
   ifmsg.ifi_change = IFF_UP;
   ifmsg.ifi_index = ifindex;