Add Logger for RpcRegistryImpl 45/9845/1
authorMarek Gradzki <mgradzki@cisco.com>
Thu, 14 Dec 2017 12:32:14 +0000 (13:32 +0100)
committerMarek Gradzki <mgradzki@cisco.com>
Thu, 14 Dec 2017 12:33:58 +0000 (13:33 +0100)
Change-Id: I6ef0133f0128fbf5cfb9ed9f0e738af0bda3a852
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
infra/rpc/impl/pom.xml
infra/rpc/impl/src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java

index 395b5f0..30d544d 100644 (file)
             <artifactId>future-converter-java8-guava</artifactId>
             <version>0.3.0</version>
         </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>
+        </dependency>
 
         <!-- tests -->
         <dependency>
             <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-api</artifactId>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 </project>
index 0b96be0..ca6441e 100644 (file)
@@ -25,6 +25,8 @@ import javax.annotation.Nullable;
 import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementationNotAvailableException;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.model.api.SchemaPath;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public final class RpcRegistryBuilder {
 
@@ -40,6 +42,7 @@ public final class RpcRegistryBuilder {
 
 
     private static final class RpcRegistryImpl implements RpcRegistry {
+        private static final Logger LOG = LoggerFactory.getLogger(RpcRegistryImpl.class);
         private final Map<SchemaPath, RpcService> services;
 
         private RpcRegistryImpl(@Nonnull final Map<SchemaPath, RpcService> services) {
@@ -51,11 +54,13 @@ public final class RpcRegistryBuilder {
         public CompletionStage invoke(@Nonnull final SchemaPath schemaPath, @Nullable final DataObject request) {
             final RpcService rpcService = services.get(schemaPath);
             if (rpcService == null) {
+                LOG.error("Missing Rpc service for schemaPath: {}", schemaPath);
                 final CompletableFuture<DataObject> result = new CompletableFuture<>();
                 result.completeExceptionally(
                     new DOMRpcImplementationNotAvailableException("Service not found: %s", schemaPath));
                 return result;
             }
+            LOG.debug("Delegating rpcRequest: {} to rpcService: {}", request, rpcService);
             return rpcService.invoke(request);
 
         }