vnet: On rx-mode set, return error for an actual error. 07/36807/1
authorWayne Morrison <wmorrison@netgate.com>
Fri, 5 Aug 2022 13:47:24 +0000 (09:47 -0400)
committerWayne Morrison <wmorrison@netgate.com>
Fri, 5 Aug 2022 14:54:44 +0000 (10:54 -0400)
In set_hw_interface_change_rx_mode(), when vnet_hw_if_set_rx_queue_mode()
returns an error it actually returns success.  This has been changed to
return a clib_error_return() value.

Type: fix
Change-Id: Iba39c875d9e15463cb6492d8a966234560a1f522
Signed-off-by: Wayne Morrison <wmorrison@netgate.com>
src/vnet/interface_cli.c

index 4de908f..ce36e3d 100644 (file)
@@ -1534,7 +1534,12 @@ set_hw_interface_change_rx_mode (vnet_main_t * vnm, u32 hw_if_index,
     {
       int rv = vnet_hw_if_set_rx_queue_mode (vnm, queue_indices[i], mode);
       if (rv)
-       goto done;
+       {
+         error = clib_error_return (
+           0, "unable to set rx-mode on interface %v queue-id %u.\n",
+           hw->name, queue_id);
+         goto done;
+       }
     }
 
 done: