hs-test: cleanup nsim test 97/42097/2
authorFlorin Coras <[email protected]>
Tue, 7 Jan 2025 09:45:05 +0000 (04:45 -0500)
committerDave Wallace <[email protected]>
Tue, 7 Jan 2025 20:22:52 +0000 (20:22 +0000)
After nsim fixes in gerrit 42052 echo tests with nsim should be stable
with multiple workers and should no longer require a ping to work.

Type: improvement

Change-Id: Ice4b353153c57b547df60d21723fa8cf953ca5d0
Signed-off-by: Florin Coras <[email protected]>
extras/hs-test/echo_test.go

index f27ad07..b21c69a 100644 (file)
@@ -24,9 +24,7 @@ func EchoBuiltinTest(s *VethsSuite) {
        s.AssertNotContains(o, "failed:")
 }
 
-// unstable with multiple workers
 func TcpWithLossTest(s *VethsSuite) {
-       s.SkipIfMultiWorker()
        serverVpp := s.Containers.ServerVpp.VppInstance
 
        serverVpp.Vppctl("test echo server uri tcp://%s/20022",
@@ -34,10 +32,6 @@ func TcpWithLossTest(s *VethsSuite) {
 
        clientVpp := s.Containers.ClientVpp.VppInstance
 
-       // Ensure that VPP doesn't abort itself with NSIM enabled
-       // Warning: Removing this ping will make VPP crash!
-       clientVpp.Vppctl("ping %s", s.Interfaces.Server.Ip4AddressString())
-
        // Add loss of packets with Network Delay Simulator
        clientVpp.Vppctl("set nsim poll-main-thread delay 0.01 ms bandwidth 40 gbit" +
                " packet-size 1400 packets-per-drop 1000")