rdma: two small improvements for rdma interface

- fix branch prediction for checking rdma ERROR flag
- add the missing right angle bracket to help message

Type: improvement
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Reviewed-by: Lijian Zhang <lijian.zhang@arm.com>
Reviewed-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I2ce667631b3e3f60939069e2a16ddba0ff12a695

diff --git a/src/plugins/rdma/cli.c b/src/plugins/rdma/cli.c
index 8f191e3..0edc83a 100644 (file)
--- a/src/plugins/rdma/cli.c
+++ b/src/plugins/rdma/cli.c
@@ -48,10 +48,10 @@ rdma_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
 VLIB_CLI_COMMAND (rdma_create_command, static) = {
   .path = "create interface rdma",
   .short_help = "create interface rdma <host-if ifname> [name <name>]"
-    " [rx-queue-size <size>] [tx-queue-size <size>]"
-    " [num-rx-queues <size>] [mode <auto|ibv|dv]"
-    " [no-multi-seg] [no-striding]"
-    " [max-pktlen <size>]",
+               " [rx-queue-size <size>] [tx-queue-size <size>]"
+               " [num-rx-queues <size>] [mode <auto|ibv|dv>]"
+               " [no-multi-seg] [no-striding]"
+               " [max-pktlen <size>]",
   .function = rdma_create_command_fn,
 };
 /* *INDENT-ON* */

diff --git a/src/plugins/rdma/input.c b/src/plugins/rdma/input.c
index f1c508a..2ff04a6 100644 (file)
--- a/src/plugins/rdma/input.c
+++ b/src/plugins/rdma/input.c
@@ -1028,7 +1028,7 @@ VLIB_NODE_FN (rdma_input_node) (vlib_main_t * vm,
       if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ADMIN_UP) == 0)
        continue;
 
-      if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ERROR))
+      if (PREDICT_FALSE (rd->flags & RDMA_DEVICE_F_ERROR))
        continue;
 
       if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_MLX5DV))