api-checkstyle: do not send the notification about the successful API checks 44/32544/1
authorAndrew Yourtchenko <ayourtch@gmail.com>
Wed, 2 Jun 2021 14:18:37 +0000 (14:18 +0000)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Wed, 2 Jun 2021 14:22:05 +0000 (14:22 +0000)
the api-checkstyle was initially done with notification for both successful
and failed api-checkstyle runs, just as a matter of precaution.
It's time to keep the notification only for the fail case, thus
fulfilling the point of notifications.

Change-Id: I41a12e7a30bc852c9280fc08a6eae426438f7d92
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
jjb/scripts/vpp/api-checkstyle.sh

index c79884f..a1c2f84 100644 (file)
@@ -32,10 +32,6 @@ if [ -f $VPP_CRC_CHECKER ]; then
     echo "Running $VPP_CRC_CHECKER_CMD"
     if $VPP_CRC_CHECKER_CMD; then
            echo "API check successful"
-
-           # for now - notify the same room during the monitoring period about the successes as well
-           WEBEX_TEAMS_MESSAGE="API check successful for $GERRIT_REFSPEC - see $BUILD_URL"
-           send_notify
     else
            RET_CODE=$?
            echo "API check failed: ret code $RET_CODE; please read https://wiki.fd.io/view/VPP/ApiChangeProcess and discuss with ayourtch@gmail.com if unsure how to proceed"