build: Add missing version.h dependency in vnet 91/28291/3
authorChris Luke <chrisy@flirble.org>
Thu, 16 Jan 2020 01:30:04 +0000 (20:30 -0500)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Wed, 12 Aug 2020 15:59:46 +0000 (15:59 +0000)
Two modules in vnet include vpp/app/version.h but there is
no explicit build dependency for this generated file. This
leaves a race condition in the build system that the Coverity
build has recently started triggering.

Change-Id: I8e2bb32feeb16e1bdd8efb0d2633cfdba60f51aa
Type: fix
Signed-off-by: Chris Luke <chrisy@flirble.org>
(cherry picked from commit c171d01cdb5183c8bf640951e94af6b1fd5e3efc)

src/vnet/CMakeLists.txt

index d237867..8bda764 100644 (file)
@@ -1520,7 +1520,7 @@ add_vpp_library(vnet
   INSTALL_HEADERS ${VNET_HEADERS}
   API_FILES ${VNET_API_FILES}
   LINK_LIBRARIES vppinfra svm vlib ${OPENSSL_LIBRARIES}
-  DEPENDS api_headers
+  DEPENDS vpp_version_h api_headers
 )
 
 ##############################################################################