session: fix use-after-free 19/22919/2
authorBenoît Ganne <bganne@cisco.com>
Wed, 16 Oct 2019 13:11:22 +0000 (15:11 +0200)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Sun, 27 Oct 2019 10:10:14 +0000 (10:10 +0000)
Type: fix

Change-Id: Ie63b80db56febc8a16bafcdd5399b2f92b6aa437
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 94d2da0b294b0084dd97217e79de18842f09356b)

src/vnet/session/mma_template.c

index e66f291..ae730e5 100644 (file)
@@ -60,8 +60,8 @@ RTT (mma_rule) * RT (mma_rules_table_rule_alloc) (RTT (mma_rules_table) * srt)
 RTT (mma_rule) *
 RT (mma_rule_free) (RTT (mma_rules_table) * srt, RTT (mma_rule) * rule)
 {
-  pool_put (srt->rules, rule);
   clib_memset (rule, 0xfa, sizeof (*rule));
+  pool_put (srt->rules, rule);
   return rule;
 }