VPP: gerrit dependent jobs causing -1 with skip set 58/11458/1
authorEd Kern <ejk@cisco.com>
Thu, 29 Mar 2018 14:23:06 +0000 (08:23 -0600)
committerEd Kern <ejk@cisco.com>
Thu, 29 Mar 2018 14:27:03 +0000 (08:27 -0600)
Even with skip vote set it seems like failed triggered
jobs end up with -1 on the gerrit. This is not acceptable

Change-Id: I0e905c3af52e891d7541f7a022337c677d6a627f
Signed-off-by: Ed Kern <ejk@cisco.com>
jjb/vpp/vpp.yaml

index 94c4834..ff01a12 100644 (file)
                 failed: true
                 unstable: true
                 notbuilt: true
-
+            override-votes: true
+            gerrit-build-notbuilt-verified-value: 0
+            notbuilt-message: 'Automatic retry of failed jobs may be in process. A proper vote should be set when retry completes.'
     builders:
         - shell:
             !include-raw-escape: ../scripts/setup_vpp_ubuntu_docker_test.sh
         - gerrit:
             server-name: 'Primary'
             trigger-on:
-                - patchset-created-event:
-                    exclude-drafts: 'true'
-                    exclude-trivial-rebase: 'false'
-                    exclude-no-code-change: 'true'
-                - patchset-uploaded-event: 'false'
                 - comment-added-contains-event:
                     comment-contains-value: 'checkstylecheck'
             projects:
                       branch-pattern: '**/{branch}'
             override-votes: true
             gerrit-build-notbuilt-verified-value: 0
+            gerrit-build-successful-verified-value: 1
             notbuilt-message: 'Automatic retry of failed jobs may be in process. A proper vote should be set when retry completes.'
             failed-message: 'Checkstyle failed. No further verify jobs will be started.'
             successful-message: 'checkstyle_success'