Fix coverity warnings, VPP-486

Change-Id: Id88805f77642187f304f8baef1f6b447728e4b5b
Signed-off-by: Dave Barach <dave@barachs.net>

diff --git a/vnet/vnet/devices/dpdk/device.c b/vnet/vnet/devices/dpdk/device.c
index 242ad79..9f40c27 100644 (file)
--- a/vnet/vnet/devices/dpdk/device.c
+++ b/vnet/vnet/devices/dpdk/device.c
@@ -323,7 +323,7 @@ dpdk_buffer_recycle (vlib_main_t * vm, vlib_node_runtime_t * node,
                     vlib_buffer_t * b, u32 bi, struct rte_mbuf **mbp)
 {
   dpdk_main_t *dm = &dpdk_main;
-  u32 my_cpu = my_cpu = vm->cpu_index;
+  u32 my_cpu = vm->cpu_index;
   struct rte_mbuf *mb_new;
 
   if (PREDICT_FALSE (b->flags & VLIB_BUFFER_RECYCLE) == 0)

diff --git a/vpp-api/python/pneum/test_pneum.c b/vpp-api/python/pneum/test_pneum.c
index 4910719..62f4a74 100644 (file)
--- a/vpp-api/python/pneum/test_pneum.c
+++ b/vpp-api/python/pneum/test_pneum.c
@@ -106,8 +106,11 @@ int main (int argc, char ** argv)
     /* Construct the API message */
     M_NOALLOC(SHOW_VERSION, show_version);
     pneum_write((char *)mp, sizeof(*mp));
+#ifndef __COVERITY__
+    /* As given, async is always 1. Shut up Coverity about it */
     if (!async)
       while (result_ready == 0);
+#endif
   }
   if (async) {
     vl_api_control_ping_t control;

diff --git a/vppapigen/node.c b/vppapigen/node.c
index 4460fd5..abb909a 100644 (file)
--- a/vppapigen/node.c
+++ b/vppapigen/node.c
@@ -1214,6 +1214,7 @@ void generate_msg_name_crc_list (YYSTYPE a1, FILE *fp)
         np = np->peer;
     }
     fprintf (fp, "\n#endif\n\n");
+    free (unique_suffix);
 }
 
 void generate_typedefs(YYSTYPE a1, FILE *fp)