[HICN-703] correct minor cmake issues and memset in manifest_format_fixed.cc

Signed-off-by: Angelo Mantellini <angelo.mantellini@cisco.com>
Change-Id: I3ed763941fa58bdfc61b9462d3f3bd268d5a76ed

diff --git a/cmake/Modules/BuildMacros.cmake b/cmake/Modules/BuildMacros.cmake
index 8914d90..c57aaa7 100644 (file)
--- a/cmake/Modules/BuildMacros.cmake
+++ b/cmake/Modules/BuildMacros.cmake
@@ -262,10 +262,12 @@ macro (build_module module)
 
   if (${CMAKE_SYSTEM_NAME} MATCHES Darwin)
     set(LINK_FLAGS "-Wl,-undefined,dynamic_lookup")
+  elseif(${CMAKE_SYSTEM_NAME} MATCHES iOS)
+    set(LINK_FLAGS "-Wl,-undefined,dynamic_lookup")
   elseif(${CMAKE_SYSTEM_NAME} MATCHES Linux)
     set(LINK_FLAGS "-Wl,-unresolved-symbols=ignore-all")
   elseif(${CMAKE_SYSTEM_NAME} MATCHES Windows)
-    set(LINK_FLAGS "/wd4275") 
+    set(LINK_FLAGS "/wd4275")
   else()
     message(FATAL_ERROR "Trying to build module on a not supportd platform. Aborting.")
   endif()

diff --git a/libtransport/includes/hicn/transport/portability/win_portability.h b/libtransport/includes/hicn/transport/portability/win_portability.h
index bfbe431..246b734 100644 (file)
--- a/libtransport/includes/hicn/transport/portability/win_portability.h
+++ b/libtransport/includes/hicn/transport/portability/win_portability.h
@@ -17,7 +17,9 @@
 \r
 #pragma once\r
 #define WIN32_LEAN_AND_MEAN\r
+#ifndef NOMINMAX\r
 #define NOMINMAX\r
+#endif\r
 #include <fcntl.h>\r
 #include <io.h>\r
 #include <parc/windows/parc_Utils.h>\r

diff --git a/libtransport/src/core/manifest_format_fixed.cc b/libtransport/src/core/manifest_format_fixed.cc
index 55280b4..7076a4c 100644 (file)
--- a/libtransport/src/core/manifest_format_fixed.cc
+++ b/libtransport/src/core/manifest_format_fixed.cc
@@ -34,7 +34,7 @@ FixedManifestEncoder::FixedManifestEncoder(Packet &packet,
       current_entry_(0),
       signature_size_(signature_size) {
   if (clear) {
-    *manifest_header_ = {0};
+        memset(manifest_header_, 0, sizeof(*manifest_header_));
   }
 }
 
@@ -51,7 +51,7 @@ FixedManifestEncoder &FixedManifestEncoder::clearImpl() {
   packet_.trimEnd(sizeof(ManifestHeader) +
                   manifest_header_->number_of_entries * sizeof(ManifestEntry));
   current_entry_ = 0;
-  *manifest_header_ = {0};
+      memset(manifest_header_, 0, sizeof(*manifest_header_));
   return *this;
 }
 

diff --git a/libtransport/src/io_modules/CMakeLists.txt b/libtransport/src/io_modules/CMakeLists.txt
index b1d2516..cf46672 100644 (file)
--- a/libtransport/src/io_modules/CMakeLists.txt
+++ b/libtransport/src/io_modules/CMakeLists.txt
@@ -13,20 +13,8 @@
 
 cmake_minimum_required(VERSION 3.5 FATAL_ERROR)
 
-if (${CMAKE_SYSTEM_NAME} MATCHES Android)
-  list(APPEND SOURCE_FILES
-    ${CMAKE_CURRENT_SOURCE_DIR}/udp/hicn_forwarder_module.cc
-    ${CMAKE_CURRENT_SOURCE_DIR}/udp/udp_socket_connector.cc
-  )
+if (${CMAKE_SYSTEM_NAME} MATCHES "^(iOS|Android|Windows)$")
 
-  list(APPEND HEADER_FILES
-    ${CMAKE_CURRENT_SOURCE_DIR}/udp/hicn_forwarder_module.h
-    ${CMAKE_CURRENT_SOURCE_DIR}/udp/udp_socket_connector.h
-  )
-
-  set(SOURCE_FILES ${SOURCE_FILES} PARENT_SCOPE)
-  set(HEADER_FILES ${HEADER_FILES} PARENT_SCOPE)
-elseif (WIN32)
   list(APPEND SOURCE_FILES
     ${CMAKE_CURRENT_SOURCE_DIR}/udp/hicn_forwarder_module.cc
     ${CMAKE_CURRENT_SOURCE_DIR}/udp/udp_socket_connector.cc