build: remove the duplicate `make install-dep` in `make pkg-verify` 68/42468/2
authorJay Wang <[email protected]>
Tue, 11 Mar 2025 10:49:43 +0000 (10:49 +0000)
committerDave Wallace <[email protected]>
Fri, 14 Mar 2025 01:58:15 +0000 (01:58 +0000)
In Makefile, when a target has multiple prerequisites, the order of
execution of prerequisites is not guaranteed. So we might encounter the
following `apt-get` lock issue when executing `make pkg-verify` due to
the duplicate execution of `make install-dep` command.

Reading package lists...
E: Could not get lock /var/lib/apt/lists/lock. It is held by process 21872 (apt-get)
E: Unable to lock directory /var/lib/apt/lists/
make[1]: *** [Makefile:404: install-dep] Error 100
make[1]: Leaving directory '/builds/software/ias/networking/vpp'
make: *** [Makefile:373: /builds/software/ias/networking/vpp/build-root/.deps.ok] Error 2

Type: fix
Change-Id: I057cebf5e31c0f3eef42f7ad07c7759a2d8e7f73
Signed-off-by: Jay Wang <[email protected]>
Makefile

index 6bd4ab6..1806b88 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -932,7 +932,7 @@ docs:
        @$(MAKE) -C $(WS_ROOT)/docs docs
 
 .PHONY: pkg-verify
-pkg-verify: install-dep $(BR)/.deps.ok install-ext-deps
+pkg-verify: $(BR)/.deps.ok install-ext-deps
        $(call banner,"Building for PLATFORM=vpp")
        @$(MAKE) CC=$(CC) -C build-root PLATFORM=vpp TAG=vpp wipe-all install-packages
        $(call banner,"Building sample-plugin")