hs-test: PromMemLeakTest improvement

do warmup with same nuber of requests and sleep before main test
section to prevent false positives

Type: test

Change-Id: Ie0ffbb27be58693f0c35c9a7ffed216ec4be1cb4
Signed-off-by: Matus Fabian <[email protected]>

diff --git a/extras/hs-test/http1_test.go b/extras/hs-test/http1_test.go
index 045109c..6e0f9d7 100644 (file)
--- a/extras/hs-test/http1_test.go
+++ b/extras/hs-test/http1_test.go
@@ -904,8 +904,14 @@ func PromMemLeakTest(s *Http1Suite) {
        s.Log(vpp.Vppctl("prom enable"))
        time.Sleep(time.Second * 3)
 
-       /* warmup request (FIB) */
-       promReq(s, url, defaultHttpTimeout)
+       /* warmup requests (FIB, pool allocations) */
+       for i := 0; i < 5; i++ {
+               time.Sleep(time.Second * 1)
+               promReq(s, url, defaultHttpTimeout)
+       }
+
+       /* let's give it some time to clean up sessions, so pool elements can be reused and we have less noise */
+       time.Sleep(time.Second * 12)
 
        vpp.EnableMemoryTrace()
        traces1, err := vpp.GetMemoryTrace()
@@ -918,7 +924,7 @@ func PromMemLeakTest(s *Http1Suite) {
        }
 
        /* let's give it some time to clean up sessions */
-       time.Sleep(time.Second * 5)
+       time.Sleep(time.Second * 12)
 
        traces2, err := vpp.GetMemoryTrace()
        s.AssertNil(err, fmt.Sprint(err))