classify: fix "show classify filter" debug CLI 99/25099/1
authorDave Barach <dave@barachs.net>
Wed, 12 Feb 2020 19:42:57 +0000 (14:42 -0500)
committerDave Barach <openvpp@barachs.net>
Thu, 13 Feb 2020 13:35:37 +0000 (13:35 +0000)
Null pointer bug, memory leak. D'oh!

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic2865757ed9cbb7f48d23c7c30b64299eb5f6674
(cherry picked from commit 104112f2d412a4576b5e0d3bbb20665d2b5bd615)

src/vnet/classify/vnet_classify.c

index 5843c36..4dff825 100755 (executable)
@@ -2074,7 +2074,6 @@ show_classify_filter_command_fn (vlib_main_t * vm,
 
       if (verbose)
        {
-         u8 *s = 0;
          u32 table_index;
 
          for (j = 0; j < vec_len (set->table_indices); j++)
@@ -2091,8 +2090,7 @@ show_classify_filter_command_fn (vlib_main_t * vm,
        }
       else
        {
-         u8 *s = 0;
-         table_index = set->table_indices[0];
+         table_index = set->table_indices ? set->table_indices[0] : ~0;
 
          if (table_index != ~0)
            s = format (s, " %u", table_index);