Add missing @Override annotations 18/9518/1
authorMarek Gradzki <[email protected]>
Wed, 22 Nov 2017 10:32:17 +0000 (11:32 +0100)
committerMarek Gradzki <[email protected]>
Wed, 22 Nov 2017 10:32:20 +0000 (11:32 +0100)
Fix isses reported by Sonar thanks to IntelliJ's code inspection.

Change-Id: I846590213e3e8ac7d3539d4de9940b32818625d5
Signed-off-by: Marek Gradzki <[email protected]>
l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java
lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java
lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java
lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java
lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java
lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java
lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java
v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java
vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java

index 74745c4..850c1ba 100644 (file)
@@ -74,6 +74,7 @@ public class Ipv4AddressCustomizerTest extends WriterCustomizerTest {
         return o -> o instanceof InstanceIdentifier && (o.getTargetType().equals(desiredClass));
     }
 
+    @Override
     @Before
     public void setUpTest() throws Exception {
         interfaceContext = new NamingContext("generatedIfaceName", IFC_CTX_NAME);
index 17ecd40..5312c2e 100644 (file)
@@ -65,6 +65,7 @@ public final class LispStateCheckServiceImpl implements LispStateCheckService, J
                 .or(STATIC_LISP_INSTANCE).isEnable(), "Lisp feature not enabled");
     }
 
+    @Override
     public boolean lispEnabled(@Nonnull final ReadContext ctx) {
         // in this case it must be dumped
         try {
index 1d78d5c..295f752 100644 (file)
@@ -101,6 +101,7 @@ public class BridgeDomainSubtableCustomizerTest
         fail("Test should throw ReadFailedException");
     }
 
+    @Override
     @Test
     public void testGetBuilder() {
         final BridgeDomainSubtableBuilder builder = customizer.getBuilder(validId);
index 5bc994a..5c09d27 100644 (file)
@@ -56,6 +56,7 @@ public class ItrRemoteLocatorSetCustomizerTest
         super(ItrRemoteLocatorSet.class, LispFeatureDataBuilder.class);
     }
 
+    @Override
     @Before
     public void setUp() throws Exception {
         validId = InstanceIdentifier.create(ItrRemoteLocatorSet.class);
index fc4344c..4012084 100644 (file)
@@ -78,6 +78,7 @@ public class LocalMappingCustomizerTest extends
     }
 
 
+    @Override
     public void setUp() {
         emptyIdentifier = InstanceIdentifier.create(EidTable.class)
                 .child(VniTable.class, new VniTableKey(12L))
index 9b7dada..ff3297e 100644 (file)
@@ -100,6 +100,7 @@ public class VrfSubtableCustomizerTest extends SubtableReaderTestCase<VrfSubtabl
         return new VrfSubtableCustomizer(api);
     }
 
+    @Override
     @Test
     public void testGetBuilder() {
         final VrfSubtableBuilder builder = customizer.getBuilder(validId);
@@ -110,6 +111,7 @@ public class VrfSubtableCustomizerTest extends SubtableReaderTestCase<VrfSubtabl
         assertNull(builder.getTableId());
     }
 
+    @Override
     @Test
     public void testMerge() {
         VniTableBuilder parentBuilder = new VniTableBuilder();
index 0ecf0e5..5140121 100644 (file)
@@ -54,6 +54,7 @@ public class ItrRemoteLocatorSetCustomizerTest extends LispWriterCustomizerTest
     private InstanceIdentifier<ItrRemoteLocatorSet> validId;
     private ItrRemoteLocatorSet validData;
 
+    @Override
     @Before
     public void setUpTest() throws Exception {
         initMocks(this);
index edf31a6..4e6fddd 100644 (file)
@@ -57,6 +57,7 @@ public class MirroredInterfacesCustomizerTest extends WriterCustomizerTest {
     @Captor
     private ArgumentCaptor<SwInterfaceSpanEnableDisable> requestCaptor;
 
+    @Override
     public void setUpTest() {
         interfaceContext = new NamingContext("iface", "iface-context");
         customizer =
index 7e6a0f7..e66a723 100644 (file)
@@ -26,6 +26,7 @@ import io.fd.vpp.jvpp.core.future.FutureJVppCore;
 import net.jmob.guice.conf.core.ConfigurationModule;
 
 public final class VppCommonModule extends AbstractModule {
+    @Override
     protected void configure() {
 
         install(ConfigurationModule.create());