hsa: remove unused test_send_buffer from echo client 28/43728/2
authorSemir Sionek <[email protected]>
Mon, 22 Sep 2025 10:05:35 +0000 (10:05 +0000)
committerFlorin Coras <[email protected]>
Mon, 22 Sep 2025 17:03:50 +0000 (17:03 +0000)
test_send_buffer was originally supposed to be used for assembling
dgrams with included data buffer offsets. As we decided on using
segments, this is not needed.

Type: fix
Change-Id: I3cdbfc077aefeecc44615cb93f7d9f3274b6b5fb
Signed-off-by: Semir Sionek <[email protected]>
src/plugins/hs_apps/echo_client.c
src/plugins/hs_apps/echo_client.h

index cae7a73..7581133 100644 (file)
@@ -839,9 +839,6 @@ ec_session_connected_callback (u32 app_index, u32 api_context, session_t *s,
   es->vpp_session_index = s->session_index;
   es->bytes_paced_target = ~0;
   es->bytes_paced_current = ~0;
-  if (ecm->transport_proto != TRANSPORT_PROTO_TCP && ecm->cfg.test_bytes)
-    vec_validate (es->test_send_buffer,
-                 ecm->max_chunk_bytes + sizeof (int) + 1);
   s->opaque = es->session_index;
 
   vec_add1 (wrk->conn_indices, es->session_index);
@@ -883,14 +880,8 @@ static void
 ec_session_disconnect_callback (session_t *s)
 {
   ec_main_t *ecm = &ec_main;
-  ec_worker_t *wrk;
-  ec_session_t *es;
   vnet_disconnect_args_t _a = { 0 }, *a = &_a;
 
-  wrk = ec_worker_get (s->thread_index);
-  es = ec_session_get (wrk, s->opaque);
-  vec_free (es->test_send_buffer);
-
   if (session_handle (s) == ecm->ctrl_session_handle)
     {
       ec_dbg ("ctrl session disconnect");
@@ -907,14 +898,8 @@ void
 ec_session_disconnect (session_t *s)
 {
   ec_main_t *ecm = &ec_main;
-  ec_worker_t *wrk;
-  ec_session_t *es;
   vnet_disconnect_args_t _a = { 0 }, *a = &_a;
 
-  wrk = ec_worker_get (s->thread_index);
-  es = ec_session_get (wrk, s->opaque);
-  vec_free (es->test_send_buffer);
-
   a->handle = session_handle (s);
   a->app_index = ecm->app_index;
   vnet_disconnect_session (a);
index 17d41c5..63e4863 100644 (file)
@@ -49,7 +49,6 @@ typedef struct ec_session_
   u64 bytes_paced_current;
   f64 send_rtt;
   u8 rtt_stat;
-  u8 *test_send_buffer;
   u64 dgrams_sent;
   u64 dgrams_received;
 } ec_session_t;