nat: nat44-ed bug fix 42/38442/2
authorWei Li <realbaseball2008@gmail.com>
Wed, 8 Mar 2023 11:36:55 +0000 (11:36 +0000)
committerOle Tr�an <otroan@employees.org>
Sat, 26 Aug 2023 13:46:26 +0000 (13:46 +0000)
fix lb static mapping
"nat44_ed_sm_o2i_add" laddr and lport

Type: fix

Signed-off-by: Wei Li <realbaseball2008@gmail.com>
Change-Id: I249a00919e8154d92cbce03f6db196c13612948f

src/plugins/nat/nat44-ed/nat44_ed.c

index 74359cc..5eee893 100644 (file)
@@ -1352,9 +1352,10 @@ nat44_ed_add_lb_static_mapping (ip4_address_t e_addr, u16 e_port,
        FIB_PROTOCOL_IP4, locals[i].vrf_id, sm->fib_src_low);
       if (!is_sm_out2in_only (flags))
        {
-         if (nat44_ed_sm_o2i_add (sm, m, e_addr, e_port, 0, proto))
+         if (nat44_ed_sm_i2o_add (sm, m, locals[i].addr, locals[i].port, 0,
+                                  proto))
            {
-             nat_log_err ("sm o2i key add failed");
+             nat_log_err ("sm i2o key add failed");
              rc = VNET_API_ERROR_UNSPECIFIED;
              // here we continue with add operation so that it can be safely
              // reversed in delete path - otherwise we'd have to track what
@@ -1430,7 +1431,7 @@ nat44_ed_del_lb_static_mapping (ip4_address_t e_addr, u16 e_port,
                                   local->fib_index, m->proto))
            {
              nat_log_err ("sm i2o key del failed");
-             return VNET_API_ERROR_UNSPECIFIED;
+             // For the same reasons as above
            }
        }