HONEYCOMB-210: decrease log level to DEBUG for empty dump msg
authorMarek Gradzki <[email protected]>
Tue, 13 Sep 2016 09:47:50 +0000 (11:47 +0200)
committerMaros Marsalek <[email protected]>
Tue, 13 Sep 2016 10:52:08 +0000 (10:52 +0000)
Empty dump message is normal state, LOG.warn
unnecessarily pollutes HC logs.

Change-Id: I9a7c3a0b2d4317d3bc04e91183afab341b779d15
Signed-off-by: Marek Gradzki <[email protected]>
vpp-common/vpp-translate-utils/src/main/java/io/fd/honeycomb/translate/v3po/util/cache/DumpCacheManager.java

index 272aa84..6c526d1 100644 (file)
@@ -62,11 +62,11 @@ public final class DumpCacheManager<T, U> {
             // binds and execute dump to be thread-save
             dump = dumpExecutor.executeDump(dumpParams);
 
-            // this is not a critical exception, so its only logged here
+            // TODO (HONEYCOMB-210): remove empty check (empty dump is normal state, special handling is not needed)
             try {
                 dumpNonEmptyCheck.assertNotEmpty(dump);
             } catch (DumpCheckFailedException e) {
-                LOG.warn("Dump for KEY[{}] has been resolved as empty", entityKey, e);
+                LOG.debug("Dump for KEY[{}] has been resolved as empty: {}", entityKey, e.getMessage());
                 return Optional.absent();
             }