Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
8b7faa7
)
fib: fix use-after-free for interface adj removal
76/22776/2
author
Benoît Ganne
<bganne@cisco.com>
Wed, 16 Oct 2019 13:08:37 +0000
(15:08 +0200)
committer
Dave Barach
<openvpp@barachs.net>
Thu, 17 Oct 2019 20:25:54 +0000
(20:25 +0000)
Type: fix
Change-Id: I82308e368d14d84f5970dad229bdcf2de7d1839d
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit
7391156ce68a81f258d65f498ec6161d694fae47
)
src/vnet/adj/adj_nbr.c
patch
|
blob
|
history
diff --git
a/src/vnet/adj/adj_nbr.c
b/src/vnet/adj/adj_nbr.c
index
cbd6691
..
7f053c8
100644
(file)
--- a/
src/vnet/adj/adj_nbr.c
+++ b/
src/vnet/adj/adj_nbr.c
@@
-823,12
+823,15
@@
adj_nbr_interface_delete_one (adj_index_t ai,
};
ip_adjacency_t *adj;
+ adj_lock(ai);
+
adj = adj_get(ai);
adj->ia_flags |= ADJ_FLAG_SYNC_WALK_ACTIVE;
fib_walk_sync(FIB_NODE_TYPE_ADJ, ai, &bw_ctx);
adj->ia_flags &= ~ADJ_FLAG_SYNC_WALK_ACTIVE;
+ adj_unlock(ai);
return (ADJ_WALK_RC_CONTINUE);
}