Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(from parent 1:
26c9d4b
)
vat: fix vat strncpy stringop-overflow
08/26408/5
author
Ray Kinsella
<mdr@ashroe.eu>
Tue, 7 Apr 2020 15:35:22 +0000
(16:35 +0100)
committer
Dave Barach
<openvpp@barachs.net>
Tue, 7 Apr 2020 21:05:53 +0000
(21:05 +0000)
Fix GCC 9.0 barf on vat strncpy.
Type: fix
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I5e41225d6ac9673a9d953046720df55e7b69c479
Signed-off-by: Dave Barach <dave@barachs.net>
src/vat/json_format.h
patch
|
blob
|
history
diff --git
a/src/vat/json_format.h
b/src/vat/json_format.h
index
d2fab90
..
260c32e
100644
(file)
--- a/
src/vat/json_format.h
+++ b/
src/vat/json_format.h
@@
-95,8
+95,7
@@
vat_json_set_string_copy (vat_json_node_t * json, const u8 * str)
u8 *ns = NULL;
int len = strlen ((const char *) str);
vec_validate (ns, len);
- strncpy ((char *) ns, (const char *) str, len + 1);
- vec_add1 (ns, '\0');
+ memcpy ((char *) ns, (const char *) str, len + 1);
vat_json_set_string (json, ns);
}