VPP-972: fix coverity warnings in the stats scraper 15/8415/1
authorDave Barach <dave@barachs.net>
Wed, 13 Sep 2017 13:18:08 +0000 (09:18 -0400)
committerDave Barach <dave@barachs.net>
Wed, 13 Sep 2017 14:04:20 +0000 (10:04 -0400)
Change-Id: I8843e57105c6c29bcdaf1e6e3bf8e9caf6bfd2ec
Signed-off-by: Dave Barach <dave@barachs.net>
src/vpp/stats/stats.c

index c78a8ae..ff52c4d 100644 (file)
@@ -1495,7 +1495,7 @@ static void
        }
 
       rp = pool_elt_at_index (sm->stats_registrations, p[0]);
-      if (!rp->stats_registrations & INTERFACE_COMBINED_COUNTERS)      // Client but doesn't want this.
+      if (!(rp->stats_registrations & INTERFACE_COMBINED_COUNTERS))    // Client but doesn't want this.
        {
          clib_warning
            ("pid %d: already disabled for interface COMBINED stats...",
@@ -1576,7 +1576,7 @@ vl_api_want_ip4_fib_stats_t_handler (vl_api_want_ip4_fib_stats_t * mp)
        }
 
       rp = pool_elt_at_index (sm->stats_registrations, p[0]);
-      if (!rp->stats_registrations & IP4_FIB_COUNTERS) // Client but doesn't want this.
+      if (!(rp->stats_registrations & IP4_FIB_COUNTERS))       // Client but doesn't want this.
        {
          clib_warning ("pid %d: already disabled for interface ip4 fib...",
                        mp->pid);
@@ -1656,7 +1656,7 @@ vl_api_want_ip6_fib_stats_t_handler (vl_api_want_ip6_fib_stats_t * mp)
        }
 
       rp = pool_elt_at_index (sm->stats_registrations, p[0]);
-      if (!rp->stats_registrations & IP6_FIB_COUNTERS) // Client but doesn't want this.
+      if (!(rp->stats_registrations & IP6_FIB_COUNTERS))       // Client but doesn't want this.
        {
          clib_warning ("pid %d: already disabled for interface ip6 fib...",
                        mp->pid);