vppinfra: fix coverity issue 205691 in pmalloc 19/28219/2
authorAndrew Yourtchenko <[email protected]>
Mon, 18 Nov 2019 10:23:54 +0000 (10:23 +0000)
committerDave Wallace <[email protected]>
Wed, 12 Aug 2020 01:22:20 +0000 (01:22 +0000)
set the address to MMAP_FAILED if mmap has failed,
so that we do not attempt to free it in the error
handling path.

Change-Id: I6e6b51a365fb68086dc20aa40a676a36af59a3ba
Type: fix
Signed-off-by: Andrew Yourtchenko <[email protected]>
(cherry picked from commit 9ce35233658d6c19a4458ec7e728b6ee75fd3ace)

src/vppinfra/pmalloc.c

index ce78ca0..cca8039 100644 (file)
@@ -331,6 +331,7 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, clib_pmalloc_arena_t * a,
       pm->error = clib_error_return_unix (0, "failed to mmap %u pages at %p "
                                          "fd %d numa %d flags 0x%x", n_pages,
                                          va, a->fd, numa_node, mmap_flags);
+      va = MAP_FAILED;
       goto error;
     }