session: deleting an application namespace cleaning up the wrong application

We call application_namespace_cleanup to remove the application which
has a reference to the application namespace when deleting an application
namespace. When we find the matching application namespace, we queue
the ns_index instead of app_index to look for the application.
This may lead to a crash.

Type: fix

Change-Id: I89c7f8d1681b4c7c1bcb16641217230a26dbe582
Signed-off-by: Steven Luong <[email protected]>

diff --git a/src/vnet/session/application.c b/src/vnet/session/application.c
index c665485..7c63ada 100644 (file)
--- a/src/vnet/session/application.c
+++ b/src/vnet/session/application.c
@@ -968,7 +968,7 @@ application_namespace_cleanup (app_namespace_t *app_ns)
   ns_index = app_namespace_index (app_ns);
   pool_foreach (app, app_main.app_pool)
     if (app->ns_index == ns_index)
-      vec_add1 (app_indices, app->ns_index);
+      vec_add1 (app_indices, app->app_index);
 
   vec_foreach (app_index, app_indices)
     {