hs-test: fix redis test on ubuntu 24.04 54/42554/2
authorFlorin Coras <[email protected]>
Wed, 26 Mar 2025 03:54:51 +0000 (23:54 -0400)
committerDave Wallace <[email protected]>
Wed, 26 Mar 2025 17:21:28 +0000 (17:21 +0000)
Noticed in local runs that after snapshots, vcl crashes due to what
appears to be a memory corruption. Given that snapshot are done in a
forked child process, probably this is some mishandling of child
processes in multi-threaded apps.

Disable snapshotting for now.

Type: fix

Change-Id: Ide2dd3d68911b936742b41992485cc06db737564
Signed-off-by: Florin Coras <[email protected]>
extras/hs-test/ldp_test.go

index 1933b0b..6ce0943 100644 (file)
@@ -90,7 +90,11 @@ func RedisBenchmarkTest(s *LdpSuite) {
 
        go func() {
                defer GinkgoRecover()
-               cmd := "redis-server --daemonize yes --protected-mode no --bind " + serverVethAddress + " --loglevel notice --logfile " + s.RedisServerLogFileName(s.Containers.ServerVpp)
+               // Avoid redis warning during startup
+               s.Containers.ServerVpp.Exec(false, "sysctl vm.overcommit_memory=1")
+               // Note: --save "" disables snapshotting which during upgrade to ubuntu 24.04 was
+               // observed to corrupt vcl memory / heap. Needs more debugging.
+               cmd := "redis-server --daemonize yes --protected-mode no --save \"\" --bind " + serverVethAddress + " --loglevel notice --logfile " + s.RedisServerLogFileName(s.Containers.ServerVpp)
                s.StartServerApp(s.Containers.ServerVpp, "redis-server", cmd, runningSrv, doneSrv)
        }()