vppinfra: deprecate clib_mem_is_vec

Use of clib_mem_is_heap_object is not reliable enough for production use
as it relies on just few bytes of memory allocator chunk header.

Type: improvement
Change-Id: I48c8adde8b6348b15477e3a015ba515eb7ee7ec2
Signed-off-by: Damjan Marion <[email protected]>

diff --git a/src/plugins/dpdk/device/format.c b/src/plugins/dpdk/device/format.c
index db90602..b06c4ce 100644 (file)
--- a/src/plugins/dpdk/device/format.c
+++ b/src/plugins/dpdk/device/format.c
@@ -238,8 +238,6 @@ format_offload (u8 * s, va_list * va)
   uword i, l;
 
   l = ~0;
-  if (clib_mem_is_vec (id))
-    l = vec_len (id);
 
   if (id)
     for (i = 0; id[i] != 0 && i < l; i++)

diff --git a/src/vppinfra/std-formats.c b/src/vppinfra/std-formats.c
index 99ea0c1..f7632e1 100644 (file)
--- a/src/vppinfra/std-formats.c
+++ b/src/vppinfra/std-formats.c
@@ -396,8 +396,6 @@ format_c_identifier (u8 * s, va_list * va)
   uword i, l;
 
   l = ~0;
-  if (clib_mem_is_vec (id))
-    l = vec_len (id);
 
   if (id)
     for (i = 0; i < l && id[i] != 0; i++)

diff --git a/src/vppinfra/vec.h b/src/vppinfra/vec.h
index 1e2f614..8f42149 100644 (file)
--- a/src/vppinfra/vec.h
+++ b/src/vppinfra/vec.h
@@ -187,18 +187,6 @@ _vec_resize_will_expand (void *v, uword n_elts, uword elt_size)
 #define vec_resize_will_expand(V, N)                                          \
   _vec_resize_will_expand (V, N, sizeof ((V)[0]))
 
-/** \brief Predicate function, says whether the supplied vector is a clib heap
-    object
-
-    @param v pointer to a vector
-    @return 0 or 1
-*/
-always_inline uword
-clib_mem_is_vec (void *v)
-{
-  return clib_mem_is_heap_object (vec_header (v));
-}
-
 /* Local variable naming macro (prevents collisions with other macro naming). */
 #define _v(var) _vec_##var