Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
62988dc
)
vlib: fix vlib_buffer_main_init_numa_node memory leak.
72/22172/2
author
Guanghua Zhang
<
[email protected]
>
Sun, 18 Aug 2019 00:35:04 +0000
(08:35 +0800)
committer
Andrew Yourtchenko
<
[email protected]
>
Sat, 21 Sep 2019 08:28:44 +0000
(08:28 +0000)
Type: fix
Signed-off-by: Guanghua Zhang <
[email protected]
>
Change-Id: I8252ed2555f5af6db2f12dc7c30e41cc1ec7dde0
(cherry picked from commit
785daf4f847a786ba618e3017752567f20f0be1c
)
src/vlib/buffer.c
patch
|
blob
|
history
diff --git
a/src/vlib/buffer.c
b/src/vlib/buffer.c
index
a49200d
..
c4c05bb
100644
(file)
--- a/
src/vlib/buffer.c
+++ b/
src/vlib/buffer.c
@@
-693,7
+693,7
@@
retry:
}
if (error)
-
return error
;
+
goto done
;
vec_reset_length (name);
name = format (name, "default-numa-%d%c", numa_node, 0);
@@
-703,9
+703,14
@@
retry:
physmem_map_index);
if (*index == (u8) ~ 0)
- return clib_error_return (0, "maximum number of buffer pools reached");
+ {
+ error = clib_error_return (0, "maximum number of buffer pools reached");
+ goto done;
+ }
- return 0;
+done:
+ vec_free (name);
+ return error;
}
void