vlib: fix coverity warning / real bug 72/28272/2
authorDave Barach <[email protected]>
Tue, 7 Jan 2020 17:29:10 +0000 (12:29 -0500)
committerDave Wallace <[email protected]>
Wed, 12 Aug 2020 14:37:52 +0000 (14:37 +0000)
The path must be next-to-impossible to hit, because the code has been
wrong for at least 5 years.

Type: fix

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I23b8c4e1631827e7931f353c561c1e19c596c598
(cherry picked from commit 5c944eef7012e7c5b363399ed92966fb659196b7)

src/vlib/cli.c

index c1cab16..300d11f 100644 (file)
@@ -1308,7 +1308,7 @@ add_sub_command (vlib_cli_main_t * cm, uword parent_index, uword child_index)
                    vec_len (p->sub_rules));
       vec_add2 (p->sub_rules, sr, 1);
       sr->name = sub_name;
-      sr->rule_index = q[0];
+      sr->rule_index = sr - p->sub_rules;
       sr->command_index = child_index;
       return;
     }