Sonar reports FIXMES as issues with higher priority as TODOs.
FIXMEs should only be used for known bugs,
not for improvements.
Also include JIRA issue ID in the TODO message.
Change-Id: I47461d948421ff17532f17ecec3ddae84239511f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
@Override
public CheckedFuture<Optional<NormalizedNode<?, ?>>, ReadFailedException> read(
@Nonnull final YangInstanceIdentifier path) {
- // FIXME switch to java.util.Optional when rest of ODL infra does
+ // TODO(HONEYCOMB-192): switch to java.util.Optional when rest of ODL infra does
final Optional<NormalizedNode<?, ?>> node = Optional.fromNullable(modification.readNode(path).orElse(null));
if (LOG.isTraceEnabled() && node.isPresent()) {
LOG.trace("ConfigSnapshot.read: {}", node.get());
}
com.google.common.base.Optional<NormalizedNode<?, ?>> getDataBefore() {
- // FIXME switch to java.util.Optional when rest of ODL infra does
+ // TODO(HONEYCOMB-192): switch to java.util.Optional when rest of ODL infra does
return com.google.common.base.Optional.fromNullable(dataCandidate.getDataBefore().orElse(null));
}
com.google.common.base.Optional<NormalizedNode<?, ?>> getDataAfter() {
- // FIXME switch to java.util.Optional when rest of ODL infra does
+ // TODO(HONEYCOMB-192): switch to java.util.Optional when rest of ODL infra does
return com.google.common.base.Optional.fromNullable(dataCandidate.getDataAfter().orElse(null));
}
delegateDependency.commit(dataTreeCandidate);
LOG.debug("Delegate commit successful. Persisting data");
- // FIXME doing full read and full write might not be the fastest way of persisting data here
+ // TODO(HONEYCOMB-163): doing full read and full write might not be the fastest way of persisting data here
final DataTreeSnapshot dataTreeSnapshot = delegateDependency.takeSnapshot();
// TODO this can be handled in background by a dedicated thread + a limited blocking queue
assertEquals(normalizedNodeOptional, normalizedNodeOptional2);
assertTrue(normalizedNodeOptional.isPresent());
assertEquals(topContainer, normalizedNodeOptional.get());
- // FIXMe use toJavaUtil everywhere
assertEquals(dataTree.takeSnapshot().readNode(TOP_CONTAINER_ID), Optional.toJavaUtil(normalizedNodeOptional));
}