quic: fix rx_callback refactoring 87/22187/2
authorNathan Skrzypczak <[email protected]>
Mon, 19 Aug 2019 15:49:56 +0000 (17:49 +0200)
committerDamjan Marion <[email protected]>
Mon, 23 Sep 2019 12:41:15 +0000 (12:41 +0000)
* check_quic_client_connected might allocate ctx
and invalidate our pointer

Type: fix

Change-Id: I885ca5a1a6db9a7765c9047a7df9cdf66c94f1cb
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 1682b51c416561b083d84194d49ff617e070eb47)

src/plugins/quic/quic.c

index 8abb850..6bf0e5e 100644 (file)
@@ -2053,10 +2053,10 @@ quic_app_rx_callback (session_t * udp_session)
          if (packets_ctx[i].thread_index != thread_index)
            continue;
 
+         check_quic_client_connected (&packets_ctx[i]);
          ctx =
            quic_ctx_get (packets_ctx[i].ctx_index,
                          packets_ctx[i].thread_index);
-         check_quic_client_connected (&packets_ctx[i]);
          quic_send_packets (ctx);
        }
       svm_fifo_dequeue_drop (f, fifo_offset);