From: Dave Barach <dave@barachs.net>
Date: Mon, 15 Mar 2021 15:10:27 +0000 (-0400)
Subject: dns: fix crash when printing unlikely msg
X-Git-Tag: v21.10-rc0~375
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=1126c90e3ae1265baaf5a1190edf49c5c39f10fe;p=vpp.git

dns: fix crash when printing unlikely msg

%U format, arguments out of order, etc.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I829a3e5808923f096369ccf6af6386060ee8b62f
---

diff --git a/src/plugins/dns/dns.c b/src/plugins/dns/dns.c
index f3ce4fc55c9..0684a104bc3 100644
--- a/src/plugins/dns/dns.c
+++ b/src/plugins/dns/dns.c
@@ -2864,9 +2864,10 @@ vnet_send_dns4_reply (vlib_main_t * vm, dns_main_t * dm,
 
   if (sw_if_index == ~0)
     {
-      clib_warning
-	("route to %U exists, fei %d, get_resolving_interface returned"
-	 " ~0", fei, format_ip4_address, &prefix.fp_addr);
+      clib_warning (
+	"route to %U exists, fei %d, get_resolving_interface returned"
+	" ~0",
+	format_ip4_address, &prefix.fp_addr, fei);
       return;
     }