From: Ole Troan <ot@cisco.com>
Date: Tue, 22 Oct 2019 06:57:31 +0000 (+0200)
Subject: cdp: disable failing tests for python3
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=bd38f7ff8ce7303eae4e8449c3b62a9dd39ed078;p=vpp.git

cdp: disable failing tests for python3

scapy in python3 does not seem to allow creating invalid protocol
packets. Suggest the maintainer rewrite the invalid tests so they
also work for python3. In the mean time they are disabled.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I554d57528422c98c6df4ba76eeae38c03f512a38
---

diff --git a/src/plugins/cdp/test/test_cdp.py b/src/plugins/cdp/test/test_cdp.py
index 7f77b4bbb01..c0e52876752 100644
--- a/src/plugins/cdp/test/test_cdp.py
+++ b/src/plugins/cdp/test/test_cdp.py
@@ -13,6 +13,8 @@ from re import compile
 from time import sleep
 from util import ppp
 import platform
+import sys
+import unittest
 
 
 """ TestCDP is a subclass of  VPPTestCase classes.
@@ -96,9 +98,13 @@ class TestCDP(VppTestCase):
         self.assert_equal(system[:length], self.device_id[:length],
                           "CDP received invalid device id")
 
+    @unittest.skipIf(sys.version_info[0] > 2,
+                     "not supported in python3/scapy")
     def test_cdp_underflow_tlv(self):
         self.send_bad_packet(3, ".")
 
+    @unittest.skipIf(sys.version_info[0] > 2,
+                     "not supported in python3/scapy")
     def test_cdp_overflow_tlv(self):
         self.send_bad_packet(8, ".")