From: Klement Sekera <ksekera@cisco.com>
Date: Fri, 22 Oct 2021 10:52:34 +0000 (+0200)
Subject: nat: fix coverity warning
X-Git-Tag: v22.06-rc0~342
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=001eb927db9ffb364d08440ca49266f70d674e6f;p=vpp.git

nat: fix coverity warning

Fix coverity warning by initialising proto variable to a dummy value.
This value is never used because consuming function uses this parameter
value only if is_addr_only flag is not set and this flag is always set
if proto value is not provided by user.

Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I041bc821a392f0746ef9f07f9b259d62884305b7
---

diff --git a/src/plugins/nat/nat44-ei/nat44_ei_cli.c b/src/plugins/nat/nat44-ei/nat44_ei_cli.c
index f3e71982e5c..36d98a46cb0 100644
--- a/src/plugins/nat/nat44-ei/nat44_ei_cli.c
+++ b/src/plugins/nat/nat44-ei/nat44_ei_cli.c
@@ -1112,7 +1112,7 @@ add_identity_mapping_command_fn (vlib_main_t *vm, unformat_input_t *input,
 
   int rv, is_add = 1, port_set = 0;
   u32 sw_if_index = ~0, port, flags, vrf_id = ~0;
-  nat_protocol_t proto;
+  nat_protocol_t proto = NAT_PROTOCOL_OTHER;
   ip4_address_t addr;
 
   flags = NAT44_EI_SM_FLAG_IDENTITY_NAT;