From: Klement Sekera <klement.sekera@gmail.com>
Date: Mon, 25 Mar 2024 14:23:55 +0000 (+0100)
Subject: vapi: avoid memory leak
X-Git-Tag: v24.10-rc0~124
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=0f4febfac3ed95a384778fc25e5223062acdf0a9;p=vpp.git

vapi: avoid memory leak

Erase removed elements to avoid memory leaks.

Type: fix
Change-Id: I1605bea8df7e08455691364efb0a12eb0d9dae93
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
---

diff --git a/src/vpp-api/vapi/vapi.hpp b/src/vpp-api/vapi/vapi.hpp
index 109af9fc522..34d8f97ad89 100644
--- a/src/vpp-api/vapi/vapi.hpp
+++ b/src/vpp-api/vapi/vapi.hpp
@@ -422,7 +422,7 @@ private:
   void unregister_request (Common_req *request)
   {
     std::lock_guard<std::recursive_mutex> lock (requests_mutex);
-    std::remove (requests.begin (), requests.end (), request);
+    requests.erase (std::remove (requests.begin (), requests.end (), request));
   }
 
   template <typename M> void register_event (Event_registration<M> *event)