From: Dave Barach <dave@barachs.net>
Date: Fri, 31 May 2019 12:41:34 +0000 (-0400)
Subject: VPP-1692: move NULL pointer check
X-Git-Tag: v19.04.1^0
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=1662c9cd23a2bbdc662221d692abff7ea680859e;p=vpp.git

VPP-1692: move NULL pointer check

TBH, this looks like merge damage or some such. Perfectly fine NULL pointer
check, about three lines after it was needed.

Change-Id: I52831062e30533a59fb76b644ee5ae389676d2ae
Signed-off-by: Dave Barach <dave@barachs.net>
---

diff --git a/src/vnet/ip/ip4_forward.c b/src/vnet/ip/ip4_forward.c
index 85e6607a963..e18a40b27e5 100644
--- a/src/vnet/ip/ip4_forward.c
+++ b/src/vnet/ip/ip4_forward.c
@@ -1853,11 +1853,6 @@ ip4_arp_inline (vlib_main_t * vm,
 	    vlib_packet_template_get_packet (vm,
 					     &im->ip4_arp_request_packet_template,
 					     &bi0);
-	  b0 = vlib_get_buffer (vm, bi0);
-
-	  /* copy the persistent fields from the original */
-	  clib_memcpy_fast (b0->opaque2, p0->opaque2, sizeof (p0->opaque2));
-
 	  /* Seems we're out of buffers */
 	  if (PREDICT_FALSE (!h0))
 	    {
@@ -1865,6 +1860,11 @@ ip4_arp_inline (vlib_main_t * vm,
 	      continue;
 	    }
 
+	  b0 = vlib_get_buffer (vm, bi0);
+
+	  /* copy the persistent fields from the original */
+	  clib_memcpy_fast (b0->opaque2, p0->opaque2, sizeof (p0->opaque2));
+
 	  /* Add rewrite/encap string for ARP packet. */
 	  vnet_rewrite_one_header (adj0[0], h0, sizeof (ethernet_header_t));