From: Neale Ranns <nranns@cisco.com>
Date: Mon, 3 Feb 2020 10:33:51 +0000 (+0000)
Subject: fib: invalid check for adj types.
X-Git-Tag: v20.09-rc0~675
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=174959cd968fc491d5ad81d30d964ec7d95c6f8d;hp=3d5f6229bccf77fcf7e0e17ab4f1b361fedd1b2b;p=vpp.git

fib: invalid check for adj types.

Type: fix

coverity found invalid logic.

Change-Id: Ic9144ac805a4e5a18aa299794fedda044dcb65fe
Signed-off-by: Neale Ranns <nranns@cisco.com>
---

diff --git a/src/vnet/adj/adj_midchain.c b/src/vnet/adj/adj_midchain.c
index 33da0ed829e..fcd6993586e 100644
--- a/src/vnet/adj/adj_midchain.c
+++ b/src/vnet/adj/adj_midchain.c
@@ -513,7 +513,7 @@ adj_nbr_midchain_update_rewrite (adj_index_t adj_index,
      * one time only update. since we don't support changing the tunnel
      * src,dst, this is all we need.
      */
-    if (adj->lookup_next_index != IP_LOOKUP_NEXT_MIDCHAIN ||
+    if (adj->lookup_next_index != IP_LOOKUP_NEXT_MIDCHAIN &&
         adj->lookup_next_index != IP_LOOKUP_NEXT_MCAST_MIDCHAIN)
     {
         adj_midchain_setup(adj_index, fixup, fixup_data, flags);